Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: probe scan cleanup #1573

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Feature: probe scan cleanup #1573

merged 6 commits into from
Jul 31, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

While testing an unrelated change set, we realised that the BMDA identification banner that's displayed was showing a duff output for the probe selected. This PR addresses this by properly sorting out how that output is generated and cleaning up some loose ends in the BMD firmware product and version string handling to help identify when things are going wrong.

The result changes

❯ src/blackmagic -s 8BB20695 -tv 1
Black Magic Debug App v1.9.0-1056-g95e768be
 for Black Magic Probe, ST-Link v2 and v3, CMSIS-DAP, J-Link and FTDI (MPSSE)
Using 1d50:6018 8BB20695 Black Magic Probe (Black Magic Debug)

to displaying

❯ src/blackmagic -s 8BB20695 -tv 1
Black Magic Debug App v1.9.0-1062-gf35b2403
 for Black Magic Probe, ST-Link v2 and v3, CMSIS-DAP, J-Link and FTDI (MPSSE)
Using 1d50:6018 8BB20695 Black Magic Debug
 Black Magic Probe v1.9.0-1023-g717ace3f-dirty

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Regression Bug caused by a regression labels Jul 28, 2023
@dragonmux dragonmux added this to the v1.10 milestone Jul 28, 2023
@dragonmux dragonmux requested a review from esden July 28, 2023 20:08
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit bff104c into main Jul 31, 2023
6 checks passed
@dragonmux dragonmux deleted the feature/probe-scan-cleanup branch August 1, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants