stm32l4.c: Fix RAM size argument to some target_add_ram() #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device->sram1 and device->sram2 are in kilobyte. A multiplication by 1024 is required when used as an argument to target_add_ram()
dragonmux
requested changes
Jul 28, 2023
dragonmux
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device->sram1 and device->sram2 are in kilobyte. A multiplication by 1024 is required when used as an argument to target_add_ram()
Detailed description
Discord 2023-07-26:
@jcamdr: The patch multiply some RAM size by 1024U, because I can't understand how it can possibly work without that.
@dragonmux: ah, that is indeed a bug re the missing
* 1024U'sYour checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues