J-Link cleanup and Target Power implementation

src/command.c

@@ -487,7 +487,8 @@ static bool cmd_target_power(target_s *t, int argc, const char **argv)
 				/* want to enable target power, but VREF > 0.5V sensed -> cancel */
 				gdb_outf("Target already powered (%s)\n", platform_target_voltage());
 			} else {
-				platform_target_set_power(want_enable);
+				if (!platform_target_set_power(want_enable))
+					DEBUG_ERROR("%s target power failed\n", want_enable ? "Enabling" : "Disabling");
 				gdb_outf("%s target power\n", want_enable ? "Enabling" : "Disabling");
 			}
 		}

src/include/platform_support.h

@@ -55,7 +55,7 @@ int platform_hwversion(void);
 void platform_nrst_set_val(bool assert);
 bool platform_nrst_get_val(void);
 bool platform_target_get_power(void);
-void platform_target_set_power(bool power);
+bool platform_target_set_power(bool power);
 void platform_request_boot(void);
 void platform_max_frequency_set(uint32_t frequency);
 uint32_t platform_max_frequency_get(void);

src/platforms/common/blackpill-f4/blackpill-f4.c

@@ -151,9 +151,10 @@ bool platform_target_get_power(void)
 	return gpio_get(PWR_BR_PORT, PWR_BR_PIN);
 }
 
-void platform_target_set_power(const bool power)
+bool platform_target_set_power(const bool power)
 {
 	gpio_set_val(PWR_BR_PORT, PWR_BR_PIN, power);
+	return true;
 }
 
 /*

src/platforms/f4discovery/platform.c

@@ -139,9 +139,10 @@ bool platform_target_get_power(void)
 	return !gpio_get(PWR_BR_PORT, PWR_BR_PIN);
 }
 
-void platform_target_set_power(const bool power)
+bool platform_target_set_power(const bool power)
 {
 	gpio_set_val(PWR_BR_PORT, PWR_BR_PIN, !power);
+	return true;
 }
 #endif
 

src/platforms/hosted/bmp_hosted.h

@@ -45,6 +45,8 @@
 #define TRANSFER_IS_DONE   (1U << 0U)
 #define TRANSFER_HAS_ERROR (1U << 1U)
 
+#define BMDA_USB_NO_TIMEOUT 0
+
 typedef struct transfer_ctx {
 	volatile size_t flags;
 } transfer_ctx_s;
@@ -99,7 +101,8 @@ void libusb_exit_function(bmp_info_s *info);
 #if HOSTED_BMP_ONLY == 1
 bool device_is_bmp_gdb_port(const char *device);
 #else
-int bmda_usb_transfer(usb_link_s *link, const void *tx_buffer, size_t tx_len, void *rx_buffer, size_t rx_len);
+int bmda_usb_transfer(
+	usb_link_s *link, const void *tx_buffer, size_t tx_len, void *rx_buffer, size_t rx_len, uint16_t timeout);
 #endif
 
 #endif /* PLATFORMS_HOSTED_BMP_HOSTED_H */

src/platforms/hosted/bmp_libusb.c

@@ -569,7 +569,8 @@ int find_debuggers(bmda_cli_options_s *cl_opts, bmp_info_s *info)
  *   sent/received may be less (per libusb's documentation). If used, rx_buffer must be
  *   suitably intialised up front to avoid UB reads when accessed.
  */
-int bmda_usb_transfer(usb_link_s *link, const void *tx_buffer, size_t tx_len, void *rx_buffer, size_t rx_len)
+int bmda_usb_transfer(
+	usb_link_s *link, const void *tx_buffer, size_t tx_len, void *rx_buffer, size_t rx_len, uint16_t timeout)
 {
 	/* If there's data to send */
 	if (tx_len) {
@@ -583,8 +584,8 @@ int bmda_usb_transfer(usb_link_s *link, const void *tx_buffer, size_t tx_len, vo
 		DEBUG_WIRE("\n");
 
 		/* Perform the transfer */
-		const int result =
-			libusb_bulk_transfer(link->device_handle, link->ep_tx | LIBUSB_ENDPOINT_OUT, tx_data, (int)tx_len, NULL, 0);
+		const int result = libusb_bulk_transfer(
+			link->device_handle, link->ep_tx | LIBUSB_ENDPOINT_OUT, tx_data, (int)tx_len, NULL, timeout);
 		/* Then decode the result value - if its anything other than LIBUSB_SUCCESS, something went horribly wrong */
 		if (result != LIBUSB_SUCCESS) {
 			DEBUG_ERROR(
@@ -600,7 +601,7 @@ int bmda_usb_transfer(usb_link_s *link, const void *tx_buffer, size_t tx_len, vo
 		int rx_bytes = 0;
 		/* Perform the transfer */
 		const int result = libusb_bulk_transfer(
-			link->device_handle, link->ep_rx | LIBUSB_ENDPOINT_IN, rx_data, (int)rx_len, &rx_bytes, 0);
+			link->device_handle, link->ep_rx | LIBUSB_ENDPOINT_IN, rx_data, (int)rx_len, &rx_bytes, timeout);
 		/* Then decode the result value - if its anything other than LIBUSB_SUCCESS, something went horribly wrong */
 		if (result != LIBUSB_SUCCESS) {
 			DEBUG_ERROR(