Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Windows debug output #1541

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Fix: Windows debug output #1541

merged 5 commits into from
Jul 18, 2023

Conversation

dragonmux
Copy link
Member

@dragonmux dragonmux commented Jul 17, 2023

Detailed description

This PR addresses a regression introduced in #1452 which saw the output on Windows get munged by a standards conformity issue in wprintf() on that OS. With the help of Microsoft, we have come to a compromise involving switching the output code page to try and guarantee correct operation.

This change also introduces printf() format string warnings for Windows, consistent with Linux and macOS compilation.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Regression Bug caused by a regression labels Jul 17, 2023
@dragonmux dragonmux added this to the v1.10 milestone Jul 17, 2023
@dragonmux dragonmux requested a review from esden July 17, 2023 20:52
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the effort to figure this out! :)

@esden esden merged commit 0128369 into main Jul 18, 2023
6 checks passed
@dragonmux dragonmux deleted the fix/windows-debug-output branch July 18, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants