Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imxrt: correct logic of debug guard #1534

Merged
merged 1 commit into from
Jul 10, 2023
Merged

imxrt: correct logic of debug guard #1534

merged 1 commit into from
Jul 10, 2023

Conversation

xobs
Copy link
Contributor

@xobs xobs commented Jul 10, 2023

Detailed description

Patch a674dff accidentally had || rather than &&, resulting in build errors when enabling debug mode on certain hardware targets. Correct this logic in order to fix builds with certain other platforms.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

@xobs
imxrt: correct logic of debug guard
10bf76b 
The previous patch accidentally had `||` rather than `&&`, resulting in
build errors when enabling debug mode on certain hardware targets.
Correct this logic in order to fix builds with certain other platforms.

Signed-off-by: Sean Cross <[email protected]>
@dragonmux dragonmux added Bug Confirmed bug Regression Bug caused by a regression labels Jul 10, 2023
@dragonmux dragonmux added this to the v1.10 milestone Jul 10, 2023
dragonmux
dragonmux approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for failing to catch this in the original PR.

@dragonmux dragonmux merged commit 745ed2e into blackmagic-debug:main Jul 10, 2023
6 checks passed
@xobs xobs deleted the fix-imxrt-debug-logic branch July 10, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@xobs @dragonmux