-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted MCLMC #675
Open
reubenharry
wants to merge
107
commits into
blackjax-devs:main
Choose a base branch
from
reubenharry:adjusted_mclmc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adjusted MCLMC #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenharry
force-pushed
the
adjusted_mclmc
branch
from
May 15, 2024 18:23
46292ed
to
3e66be7
Compare
junpenglao
reviewed
May 29, 2024
I think this is ready to review again @junpenglao EDIT: actually, let me first update the tuning algorithm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change is also made to$L$ . This is convenient since the user may or not want partial refreshment (in the unadjusted case, we find that it is always beneficial, but don't know yet in the adjusted case)
partially_refresh_momentum
, which allows (adjusted) MCHMC to be the limit of MCLMC with infiniteAddresses #676.
Checklist:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;