Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove option to give
initial_position
fromrun_inference_algorithm
.Description:
run_inference_algorithm
currently uses a try-except clause to allow the user to either provide an initial position or an initial state. This has led to some problems, when theexcept
clause fails to trigger.More broadly, there doesn't seem to be a good reason to
Solution:
Make
run_inference_algorithm
only takeinitial_state
, so that the caller ofrun_inference_algorithm
is responsible for providinginitial_state
frominitial_position
, rather than deferring this task.A few important guidelines and requirements before we can merge your PR:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;