Refactor divergence check to each sampler #579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #391.
The change end up quite small that it do away divergence check in
proposal.py
, and compute divergence only when needed (inhmc.py
andtrajectory.py
). The functions inproposal.py
is more general than just HMC that we see pattern like:So removing the check would keeps the functions in
proposal.py
simpler and more focus.However, we cannot push the check the top most level (ie., it need to remain in
trajectory.py
), as the information is used during the trajactory building and it is not easy to refactor it away.