Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit variables in Liquid-style tag 'include with' #299

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

pmenhart
Copy link
Contributor

  • Only String literals were permitted as parameter of include with "with", e.g. {% include 'snippet' with 'red' %}
  • Now it is possible to reference objects (variables): {% include 'snippet' with color %}
  • Confirmed with the reference Liquid/Ruby implementation

* Only String literals were permitted as parameter of `include with 'param'`
* Now it is possible to reference objects: `include with var`
@pmenhart pmenhart marked this pull request as draft April 24, 2024 01:17
@pmenhart pmenhart marked this pull request as ready for review April 24, 2024 01:17
@pmenhart pmenhart closed this Apr 24, 2024
@pmenhart pmenhart reopened this Apr 24, 2024
@msangel msangel merged commit 4854bbc into bkiers:master Apr 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants