Clean up compiler warnings #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se of new Filters class(immutable)
…e in it, counter should be moved in context (probably as registry)
Expose Filters and Insertions from a TemplateContext, and simplify creating a new child context by adding a newChildContext() helper method.
Infer generic parameters for Map, List, etc. Cease use of deprecated Java API. Suppress "unchecked", "hiding" warnings where appropriate. Add missing serialVersionUID where necessary. Use getRenderSettings()/getParseSettings() instead of deprecated access. Remove unused class members. Remove unused imports.
Replace deprecated org.junit.Assert.assertThat with org.hamcrest.MatcherAssert.assertThat. Organize imports. Replace HashMap subclass with Collections.singletonMap where possible. Add SupressWarnings "unused", "deprecation", "serial" where appropriate. DateTest: Add additional checks for vararg method.
Merged
|
Merged there: #280 |
|
My opinions:
Clean up code in src/main/test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Eclipse IDE is full of liqp warnings, making it hard to see the actual problems. Let's clean these up a bit.
Clean up code in src/main/java
Clean up code in src/main/test
This change is rebased upon #274 and https://github.com/bkiers/Liqp/pull/269/commits