Show a dash if test is not published #512 #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hupf
approved these changes
Oct 30, 2023
| @@ -11,6 +11,7 @@ export class TestPointsPipe implements PipeTransform { | |||
|
|
|||
| transform(input: Test, studentId: number, label = "tests.points"): string { | |||
| if (!input.IsPointGrading) return ""; | |||
| if (!input.IsPublished) return "-"; | |||
There was a problem hiding this comment.
Wäre ist beim oberen Statement (if (!input.IsPointGrading) return "";) nicht auch sinnvoll einen "–" zu rendern?
There was a problem hiding this comment.
Ich bin nicht sicher. Falls der Strich als "da kommt später noch eine Zahl" interpretiert wird (was ja hier nicht der Fall wäre) ist keine Anzeige möglicherweise besser...?
caebr
force-pushed
the
feature/512-my-grades-hide-unpublished-points
branch
from
b9c5342
to
bf72a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siehe #512