Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/580 ux review #598

Merged
merged 4 commits into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ a:hover {
background: $sand-hover;
}

a:focus-visible {
outline-width: 2px;
outline-offset: -2px;
}

div {
display: flex;
justify-content: space-between;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
</button>
<button
type="button"
[attr.aria-label]="'dashboard.timetable.previousDay' | translate"
class="btn btn-secondary previous-day"
(click)="gotoPreviousDay()"
>
<span class="material-icons">chevron_left</span>
</button>
<button
type="button"
[attr.aria-label]="'dashboard.timetable.nextDay' | translate"
class="btn btn-secondary next-day"
(click)="gotoNextDay()"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
isAuthenticated: (isAuthenticated$ | async)
} as data"
>
<div
<button
type="button"
[attr.aria-label]="'my-notifications.title' | translate"
(click)="toggleNotificationsPopup()"
id="notifications-button"
class="btn notifications-button p-0 m-0"
class="btn btn-link notifications-button p-0 m-0"
>
<span
class="notifications-bell"
Expand Down Expand Up @@ -40,7 +42,7 @@
"
>{{ data.notificationsCount }}</span
>
</div>
</button>
<div
class="notifications-popup border"
id="notifications-popup"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ <h1>{{ 'my-profile.title' | translate }}</h1>
<a
class="btn btn-primary btn-icon float-end me-2"
routerLink="edit"
aria-label="edit"
[attr.aria-label]="'my-profile.edit.title' | translate"
>
<i class="material-icons">edit</i>
</a>
Expand Down
2 changes: 2 additions & 0 deletions src/assets/locales/de-CH.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@
"title": "Stundenplan",
"no-entries": "Am gewählten Tag sind keine Stundenplaneinträge vorhanden.",
"today": "Heute",
"nextDay": "nächster Tag",
"previousDay": "vorheriger Tag",
"subscribe-calendar": "Kalender abonnieren",
"table": {
"time": "Zeit",
Expand Down
2 changes: 2 additions & 0 deletions src/assets/locales/fr-CH.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@
"title": "Horaire",
"no-entries": "Aucune entrée d'horaire n'est disponible à la date sélectionnée.",
"today": "Aujourd'hui",
"nextDay": "jour suivant",
"previousDay": "jour précédent",
"subscribe-calendar": "S'abonner au calendrier",
"table": {
"time": "Heure",
Expand Down
Loading