Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use subscription fields as string #124

Closed
wants to merge 1 commit into from

Conversation

Xillians
Copy link
Contributor

TL;DR

according to tripletex api, the /event/subscirption expects the fieldto be a string rather than an array

What's changed

  • turned subscription events endpoint to expect string

Why

This is to make the subscription use the expected input to avoid getting 422 errors.

@braaar
Copy link
Member

braaar commented Aug 27, 2024

It appears to me that the fields value is turned into a comma-separated string in the actuall call

@Xillians
Copy link
Contributor Author

It appears to me that the fields value is turned into a comma-separated string in the actuall call

That was the intention. The documentation for event/subscription was added to the description along with the explanation
image

@braaar
Copy link
Member

braaar commented Aug 27, 2024

This PR is just circumventing the toString method by expecting the SDK user to create a comma separated string. I don't see the point of this change.

@Xillians Xillians closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants