Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove showPasswordless conditionals #11928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Nov 8, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14654

📔 Objective

We introduced a showPasswordless client-side flag in order to roll out the Login with Device feature, a long time ago, with #3424. This was before LaunchDarkly was a thing, so this is a client-side flag only.

This flag was never cleaned up, and the conditional logic around it was built into the new LoginComponent - since it was still used in the existing one.

This PR removes the conditional logic from both the old LoginComponentV1 and the new LoginComponent that was introduced with #10856.

No behavior should change here, as the flag was true in all environments. We just need to be sure that "Login with Device" still appears on all clients, with both UIs.

📸 Screenshots

Old UI

Web

image

Desktop

image

Extension

image

New UI

Web

image

Desktop

image

Extension

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Removed showPasswordless conditionals Remove showPasswordless conditionals Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (5592d64) to head (1fbf677).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/auth/src/angular/login/login.component.ts 0.00% 3 Missing ⚠️
apps/browser/src/auth/popup/login-v1.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11928   +/-   ##
=======================================
  Coverage   33.41%   33.42%           
=======================================
  Files        2841     2841           
  Lines       89008    88990   -18     
  Branches    16979    16975    -4     
=======================================
+ Hits        29744    29746    +2     
+ Misses      56927    56907   -20     
  Partials     2337     2337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as off-topic.

@trmartin4 trmartin4 marked this pull request as ready for review November 8, 2024 19:30
@trmartin4 trmartin4 requested review from a team as code owners November 8, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants