Remove showPasswordless conditionals #11928
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14654
📔 Objective
We introduced a
showPasswordless
client-side flag in order to roll out the Login with Device feature, a long time ago, with #3424. This was before LaunchDarkly was a thing, so this is a client-side flag only.This flag was never cleaned up, and the conditional logic around it was built into the new
LoginComponent
- since it was still used in the existing one.This PR removes the conditional logic from both the old
LoginComponentV1
and the newLoginComponent
that was introduced with #10856.No behavior should change here, as the flag was
true
in all environments. We just need to be sure that "Login with Device" still appears on all clients, with both UIs.📸 Screenshots
Old UI
Web
Desktop
Extension
New UI
Web
Desktop
Extension
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes