Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14850] Flatpak development & qa artifacts #11925

Open
wants to merge 11 commits into
base: km/pm-14252/switch-to-oo7
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 8, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14850

📔 Objective

Adds QA artifacts for flatpak, and adds npm command to pack flatpak for development.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Detailse697acb7-e7f8-4462-8cfd-a731ecbb436e

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1331 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1380 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 317 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 927 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 927 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 317 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1331 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1380 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 305
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1368
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1319
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 915
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 915
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1319
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1368
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 305

@quexten quexten changed the base branch from main to km/pm-14252/switch-to-oo7 November 12, 2024 12:25
@quexten quexten changed the title Km/flatpak devel [PM-14850] Flatpak development & qa artifacts Nov 12, 2024
@quexten quexten marked this pull request as ready for review November 12, 2024 13:00
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.42%. Comparing base (b0fcfc1) to head (da68061).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           km/pm-14252/switch-to-oo7   #11925   +/-   ##
==========================================================
  Coverage                      33.42%   33.42%           
==========================================================
  Files                           2841     2841           
  Lines                          89008    89008           
  Branches                       16979    16979           
==========================================================
  Hits                           29751    29751           
  Misses                         56920    56920           
  Partials                        2337     2337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant