[PM-14567] - fix routes. update copy and headers #11908
Open
+715
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11908 +/- ##
=======================================
Coverage 33.48% 33.48%
=======================================
Files 2845 2845
Lines 89046 89046
Branches 16982 16982
=======================================
Hits 29817 29817
Misses 56889 56889
Partials 2340 2340 ☔ View full report in Codecov by Sentry. |
djsmith85
requested changes
Nov 7, 2024
| > | ||
| <bit-nav-item | ||
| [text]="'riskInsights' | i18n" | ||
| route="access-intelligence/risk-insights" |
There was a problem hiding this comment.
There was a problem hiding this comment.
@djsmith85 This PR also updates the route to reflect these changes.
access-intelligence - https://github.com/bitwarden/clients/pull/11908/files#diff-68379c0fec3ef65ee2e9916d3d4234c0ff0298cb0b7fec389e1c87c8513debe5R66
risk-insights - https://github.com/bitwarden/clients/pull/11908/files#diff-c6135b030fa024cbafb87c5c742698b44951a5e2fff7c9a6f42a59c34c96a9d2
jaasen-livefront
changed the title
djsmith85
previously approved these changes
Nov 7, 2024
ttalty
previously approved these changes
Nov 11, 2024
jaasen-livefront
requested review from
dani-garcia,
merissaacosta and
ike-kottlowski
jaasen-livefront
force-pushed
the
PM-14567
branch
from
9a3b83c
to
4d3716d
Compare
|
New Issues
Fixed Issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14557
📔 Objective
This PR updates the access-intelligence routing and navigation to match design. It also updates some of the copy and adds logic for hiding the "Last updated" if there are no apps to check.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes