Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11704] fix large excluded domain icon #11896

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

evan-livefront
Copy link
Collaborator

@evan-livefront evan-livefront commented Nov 7, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11703

📔 Objective

Fix link that is too large

📸 Screenshots

Screenshot 2024-11-07 at 11 02 45 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@evan-livefront evan-livefront requested a review from a team as a code owner November 7, 2024 17:04
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Logo
Checkmarx One – Scan Summary & Detailsc975b132-15db-4744-9e97-9f53fa067ff3

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/platform/components/approve-ssh-request.html: 6
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 212
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 209
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM

More results are available on AST platform

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.49%. Comparing base (c496792) to head (10a88d3).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11896   +/-   ##
=======================================
  Coverage   33.48%   33.49%           
=======================================
  Files        2845     2845           
  Lines       89046    89046           
  Branches    16982    16982           
=======================================
+ Hits        29817    29824    +7     
+ Misses      56889    56882    -7     
  Partials     2340     2340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants