Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12092] Community/10994/item type add #11773

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cd-bitwarden
Copy link
Contributor

@cd-bitwarden cd-bitwarden commented Oct 29, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12092
PR to build artifacts for "#10994"

📔 Objective

Branch made from community PR so we can merge it in.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cd-bitwarden cd-bitwarden requested a review from a team as a code owner October 29, 2024 16:20
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.44%. Comparing base (40f2e15) to head (b491d23).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/desktop/src/vault/app/vault/vault.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11773   +/-   ##
=======================================
  Coverage   33.44%   33.44%           
=======================================
  Files        2844     2844           
  Lines       89043    89043           
  Branches    16982    16983    +1     
=======================================
  Hits        29777    29777           
  Misses      56929    56929           
  Partials     2337     2337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cd-bitwarden cd-bitwarden added the hold do not merge, do not approve yet label Oct 29, 2024
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3fd6bdc3-9ce6-4ec8-9826-9507f7236dc5

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants