Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12395] - hide free bitwarden families button when not available #11184

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12395

📔 Objective

This PR fixes an issue where the "Free Bitwarden Families" button was showing in the browser extension for enterprise users even when it wasn't available.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested review from addisonbeck, Hinton and djsmith85 and removed request for Hinton September 20, 2024 21:13
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.98%. Comparing base (9a89ef9) to head (b11f5a7).
Report is 31 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bout-page/more-from-bitwarden-page-v2.component.ts 0.00% 1 Missing ⚠️
...sole/services/organization/organization.service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11184   +/-   ##
=======================================
  Coverage   34.98%   34.98%           
=======================================
  Files        2712     2712           
  Lines       84577    84579    +2     
  Branches    16069    16069           
=======================================
+ Hits        29587    29588    +1     
- Misses      54019    54020    +1     
  Partials      971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details73a30ee5-e977-4e0e-9102-810b061a2648

No New Or Fixed Issues Found

@djsmith85 djsmith85 merged commit 7f33954 into main Sep 25, 2024
66 checks passed
@djsmith85 djsmith85 deleted the PM-12395 branch September 25, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants