-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path query for chromium #62
Open
mattyclarkson
wants to merge
13
commits into
bitovi:master
Choose a base branch
from
mattyclarkson:chromium
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 29, 2016
-
The PID is in the first column of 'ps'
On GNU/Linux anyway. Assume SunOS is the same
Configuration menu - View commit details
-
Copy full SHA for c2f0ecd - Browse repository at this point
Copy the full SHA c2f0ecdView commit details -
Provides more flexibility to find the PID
Configuration menu - View commit details
-
Copy full SHA for 65420d6 - Browse repository at this point
Copy the full SHA 65420d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9357b7d - Browse repository at this point
Copy the full SHA 9357b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca62680 - Browse repository at this point
Copy the full SHA ca62680View commit details -
Find the chromium instance correctly
The chromium binary is actually a script that starts the /usr/lib/chromium binary with the correct arguments. We just need to search for the chromium instance that doesn't have a '--type' parameter
Configuration menu - View commit details
-
Copy full SHA for 084c409 - Browse repository at this point
Copy the full SHA 084c409View commit details
Commits on May 24, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 7cfca19 - Browse repository at this point
Copy the full SHA 7cfca19View commit details -
When chrome fires up it requests for /favicon.ico automatically. As chrome can start up in a tab, it won't be killed and the request can occur during the start up of the next browser. This makes sure to only test the user agent when the request is for the root page.
Configuration menu - View commit details
-
Copy full SHA for e7f7b27 - Browse repository at this point
Copy the full SHA e7f7b27View commit details -
This can provide more information in the mocha message
Configuration menu - View commit details
-
Copy full SHA for 4d40067 - Browse repository at this point
Copy the full SHA 4d40067View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf859b2 - Browse repository at this point
Copy the full SHA cf859b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f55e4e - Browse repository at this point
Copy the full SHA 8f55e4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for db09be2 - Browse repository at this point
Copy the full SHA db09be2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bf7daf - Browse repository at this point
Copy the full SHA 6bf7dafView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0ac5c2 - Browse repository at this point
Copy the full SHA e0ac5c2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.