Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] User Environmental Variables #72279

Conversation

seppo498573908457
Copy link

Description of the change

Added new environmental variables: "REDIS_REQUIREPASS", "REDIS_USER" and "REDIS_MASTER_USER". Modified default value for "REDIS_MASTER_PASSWORD".
Modified scripts to make use of the new variables and retaining backwards compatibility.
Modified the README to reflect changes.

Fixed a bug, "--masterauth" now correctly receives value from "REDIS_MASTER_PASSWORD".

Benefits

Allows use of ACL users in the environmental variables.
Retains backwards compatibility with old configurations by using default values for new variables and this is considered in script changes.

Applicable issues

Additional information

Similar changes were made to "redis-cluster" image on a different PR.

Updated README.md with new environmental variables and a chapter about users and passwords.
Signed-off-by: Jukka Maljanen <[email protected]>
@github-actions github-actions bot added redis triage Triage is needed labels Sep 9, 2024
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 9, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 9, 2024
@github-actions github-actions bot removed the request for review from carrodher September 9, 2024 13:32
@andresbono
Copy link
Contributor

Hi @seppo498573908457, thank you for submitting this PR. In the meantime we review your contribution and give you some feedback, we would need the changes to be applied in all the branches, that means 6.2 as well. Are your proposed changes compatible with 6.2?

@seppo498573908457
Copy link
Author

It looks like your script files have not changed on relevant parts, ie. they should be compatible. I will still need to test it out and check some of the Redis settings...

@andresbono
Copy link
Contributor

Thank you for checking it. Please, let us know if you find some incompatibility in your testing.

@carrodher carrodher requested review from jotamartos and removed request for andresbono October 1, 2024 16:45
@carrodher carrodher assigned jotamartos and unassigned andresbono Oct 1, 2024
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Oct 17, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/redis-cluster] Cannot create Redis cluster with other than default user
5 participants