-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/redis] User Environmental Variables #72279
[bitnami/redis] User Environmental Variables #72279
Conversation
Updated README.md with new environmental variables and a chapter about users and passwords. Signed-off-by: Jukka Maljanen <[email protected]>
Hi @seppo498573908457, thank you for submitting this PR. In the meantime we review your contribution and give you some feedback, we would need the changes to be applied in all the branches, that means |
It looks like your script files have not changed on relevant parts, ie. they should be compatible. I will still need to test it out and check some of the Redis settings... |
Thank you for checking it. Please, let us know if you find some incompatibility in your testing. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Description of the change
Added new environmental variables: "REDIS_REQUIREPASS", "REDIS_USER" and "REDIS_MASTER_USER". Modified default value for "REDIS_MASTER_PASSWORD".
Modified scripts to make use of the new variables and retaining backwards compatibility.
Modified the README to reflect changes.
Fixed a bug, "--masterauth" now correctly receives value from "REDIS_MASTER_PASSWORD".
Benefits
Allows use of ACL users in the environmental variables.
Retains backwards compatibility with old configurations by using default values for new variables and this is considered in script changes.
Applicable issues
Additional information
Similar changes were made to "redis-cluster" image on a different PR.