-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/airflow] Consistency on Airflow configuration & init improvements #30349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments Signed-off-by: juan131 <[email protected]>
Signed-off-by: juan131 <[email protected]>
github-actions
bot
added
airflow
verify
Execute verification workflow for these changes
bitnami
labels
Nov 8, 2024
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: juan131 <[email protected]>
4 tasks
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @juan131
I've just left a suggestion. Could you give it a look?
Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Juan Ariza Toledano <[email protected]>
fmulero
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR changes how Airflow configuration is adapted based on users parameters: instead of setting a bunch of env. vars and relying on main containers' init logic to prepare the config file(s), everything (except config properties containing credentials) is prepared by the chart in the ConfigMap, then init containers are used to complete configuration with config properties containing credentials.
The goals is to ensure the
airflow.cfg
file is the same on every Airflow component (scheduler, worker, web server, etc.) given currently there are small discrepancies. Also, similar to #30246, applying changes related to credentials on init-containers has important benefits on bootstrapping, issues isolation and resource usage efficiency.Benefits
Possible drawbacks
None
Applicable issues
Additional information
Other changes included:
pod_template.yaml
is moved to its own ConfigMap.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm