Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/opensearch] Add specific annotations to the svcHeadless and specific ConfigMap for ca.crt #29495

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

micheelengronne
Copy link

Description of the change

There are 2 changes:

  • svcHeadless resources of Opensearch can now have specific annotations.
  • ca.crt can be called from a specific ConfigMap.

Benefits

Specific annotations provide a way to add behaviour stricly scoped per svcHeadless Service. For instance, TLS cert creation.

ca.crt called from a specific ConfigMap provides a way to use the inject-cabundle feature of Openshift.

The 2 changes coupled together provide a way to automate the handling of certs through the Openshift API.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@micheelengronne
Copy link
Author

Sorry, the PR is not quite finished yet. I didn't want to lose it.

@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Here you can see the specific steps for your case.

Feel free to reach out if you have any questions or need assistance with the signing process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opensearch triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants