Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/nginx] stream server blocks #29491

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TrueGameover
Copy link

Description of the change

Configuration allowed for stream server blocks in nginx container.

Benefits

Can configure stream server blocks.

Possible drawbacks

no

Applicable issues

Additional information

bitnami/containers#72353

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 18, 2024
@github-actions github-actions bot removed the request for review from carrodher September 18, 2024 07:03
jotamartos
jotamartos previously approved these changes Sep 19, 2024
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just a minor suggestion

Comment on lines 248 to +254
{{- if .Values.extraEnvVars }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }}
{{- end }}
{{- if or .Values.streamServerBlock .Values.existingStreamServerBlockConfigmap }}
- name: NGINX_ENABLE_STREAM
value: "true"
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- if .Values.extraEnvVars }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }}
{{- end }}
{{- if or .Values.streamServerBlock .Values.existingStreamServerBlockConfigmap }}
- name: NGINX_ENABLE_STREAM
value: "true"
{{- end }}
{{- if or .Values.streamServerBlock .Values.existingStreamServerBlockConfigmap }}
- name: NGINX_ENABLE_STREAM
value: "true"
{{- end }}
{{- if .Values.extraEnvVars }}
{{- include "common.tplvalues.render" (dict "value" .Values.extraEnvVars "context" $) | nindent 12 }}
{{- end }}

Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version of the Chart, there was a new release in the meantime.

Note: You will need to pull your branch as I resolved a conflict in the changelog file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress nginx verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants