Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/tomcat] Fix initContainers indent #29448

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

migruiz4
Copy link
Member

Description of the change

Fixes initContainer indent when volumePermissions.enabled=true

Possible drawbacks

None known.

Applicable issues

Additional information

The current indent works when used by itself:

initContainers:
- name: init
...

But when used in combination with volumePermissions renders into an invalid yaml caused by the indentation difference:

initContainers:
  - name: volume-permissions
     ...
- name: init
...

This PR fixes the issue by setting both indentations to 2 spaces:

initContainers:
  - name: volume-permissions
     ...
  - name: init
  ...

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Sep 16, 2024
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami tomcat verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/tomcat] Unable to install tomcat if an initContainers is set within a yaml value file.
3 participants