[bitnami/common] Drop unused custom empty password validators #29432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you so much for the PRs! Just like the previous one, could you separate it into different PRs? Our automations work in a one PR per app basis |
LeoColomb
changed the title
Promote generic `common.secrets.passwords.manage` use Signed-off-by: Léo Colombaro <[email protected]>
LeoColomb
force-pushed
the
feat/clean-validators
branch
from
9ca7b11
to
f98aa21
Compare
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
javsalgar
previously approved these changes
Sep 19, 2024
|
Let me know if anything additional need to be done in here 😊 @javsalgar |
Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
juan131
approved these changes
Oct 14, 2024
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
…i#29432) Signed-off-by: Michael Faherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
With the new password management common helper (
common.secrets.passwords.manage), custom/dedicated empty password validators are not necessary anymore.In fact, most of them are already not used anymore.
The following helpers are dropped:
common.validations.values.cassandra.passwordscommon.validations.values.cassandra.passwords#29441common.validations.values.mongodb.passwordscommon.validations.values.mysql.passwordscommon.validations.values.mysql.passwords#29442common.validations.values.postgresql.passwordscommon.validations.values.redis.passwordsPlease note that
common.validations.values.mariadb.passwordshas not been removed because still referenced a lot across the charts. Probably better to handle it in a separate PR.Benefits
Reduce the size and the complexity of the empty password validators, simplifying maintenance.
Also promote indirectly the use of
common.secrets.passwords.manage, handling the validation.Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.