[bitnami/contour] Allow replacing certgen with cert-manager #29416
+108
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaarni
force-pushed
the
contour-xds-cert-manager
branch
from
97b9228
to
74af472
Compare
* Add an option to use cert-manager to issue certificates for TLS connection between Contour and Envoy. Signed-off-by: Tero Saarni <[email protected]>
tsaarni
force-pushed
the
contour-xds-cert-manager
branch
from
182d903
to
14f8a95
Compare
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This update introduces a new option,
useCertManager. When set totrue, it replaces Contour's certgen with cert-manager by deployingIssuerandCertificateresources to issue TLS certificates for communication between Contour and Envoy. The default value isfalse.Benefits
Cert-manager automates certificate life-cycle management, including renewal before expiration. Certgen, on the other hand, issues certificates with a 1-year validity period and does not support automatic rotation.
Possible drawbacks
Enabling this option introduces a dependency on cert-manager.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm