Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/valkey-cluster] fix: add apiVersion and kind to volumeClaimTemplates #29354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aqeelat
Copy link
Contributor

@aqeelat aqeelat commented Sep 11, 2024

Description of the change

Continuation of the work in #29289

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Abdullah Alaqeel <[email protected]>
Signed-off-by: Abdullah Alaqeel <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Sep 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 11, 2024
@github-actions github-actions bot removed the request for review from javsalgar September 11, 2024 09:03
@jotamartos
Copy link
Contributor

Thanks for your contribution @aqeelat. I approved this PR but it's not possible to verify it right now. I'll ensure this PR passes the tests once the system is available.

@jotamartos jotamartos enabled auto-merge (squash) September 11, 2024 15:49
@jotamartos
Copy link
Contributor

Hi @aqeelat,

Due to recent changes in our pipelines, could you please rebase your branch with the latest changes in our main branch so the changes can be verified properly?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress valkey-cluster verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants