fix: Improve external Redis validation in Argo CD chart #29341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current validation for external Redis in the Argo CD Helm chart is triggering false positives when Redis is disabled and an external Redis is configured. This commit updates the validation logic to properly check for the presence of external Redis configuration when the built-in Redis is disabled.
Changes:
argocd.validateValues.externalRedis
function in _helpers.tplThis change ensures that users can successfully deploy Argo CD with an external Redis configuration without encountering false validation errors. It maintains backwards compatibility while improving the user experience for those using external Redis instances.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm