Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve external Redis validation in Argo CD chart #29341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesmr89
Copy link

The current validation for external Redis in the Argo CD Helm chart is triggering false positives when Redis is disabled and an external Redis is configured. This commit updates the validation logic to properly check for the presence of external Redis configuration when the built-in Redis is disabled.

Changes:

  • Update the argocd.validateValues.externalRedis function in _helpers.tpl
  • Add separate checks for external Redis host and port
  • Provide more specific error messages for missing configuration

This change ensures that users can successfully deploy Argo CD with an external Redis configuration without encountering false validation errors. It maintains backwards compatibility while improving the user experience for those using external Redis instances.

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

The current validation for external Redis in the Argo CD Helm chart is
triggering false positives when Redis is disabled and an external Redis
is configured. This commit updates the validation logic to properly check
for the presence of external Redis configuration when the built-in Redis
is disabled.

Changes:
- Update the `argocd.validateValues.externalRedis` function in _helpers.tpl
- Add separate checks for external Redis host and port
- Provide more specific error messages for missing configuration

This change ensures that users can successfully deploy Argo CD with an
external Redis configuration without encountering false validation errors.
It maintains backwards compatibility while improving the user experience
for those using external Redis instances.

Signed-off-by: jamesmr89 <[email protected]>
@carrodher
Copy link
Member

Thanks for your contribution! Please note it's needed to bump the chart version in the Chart.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants