[bitnami/flux] Added Lookup Flag when Installing CRDs

[jl-beast]

Description of the change

Added a flag to the values that allows a check to see if the CRDs already exist when installing the chart.

Benefits

Gives users more control over the install of the CRDs when installing Flux, preventing scenarios wherein you could not install flux because the CRDs already existed.

Possible drawbacks

Added Chart Complexity and Variance.

Applicable issues

• fixes [bitnami/flux] Use Helm Lookup for CRDs #28812

Additional information

I locally tested both helm install and helm template, both with and without --dry-run=server.

I am not particularly certain what to do regarding the:
# Conditional: .Values.____.installCRDs
on the top of each CRD file, given that I added an additional if statement. Let me know if that is relevant.

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[jl-beast]

Any Updates?

[jotamartos]

Hi @jl-beast,

Thanks for taking the time to create this PR. However, I can't accept this as the next version of the solution will overwrite your changes. There is a GitHub action that updates those crds based on the files in the upstream project. You can learn more about that here.

There are 2 options here:

• Update the "Conditional" line to only include one single if in those crd files
• Check how the upstream project enables that feature

[jl-beast]

@jotamartos

I have reviewed and updated the conditionals.

However, given that files may contain multiple different CRDs when downloaded from their remote release sources, this means that lookup must be attuned to selecting a particular one. For this purpose, I selected the first in file.

This does however introduce additional risk, in that, if a kubernetes clusters include "Provider", but not "Alert" (for example), then it will attempt to install nonetheless with the setting. My thought, however, is that the cluster's operations with a deleted CRD for flux should already break it for each controller. That is likely a bigger concern for the cluster operator than lookup failing on a chart.

[jotamartos]

Could you investigate how this is done in the upstream chart and update the templates based on that?

[jotamartos]

As I mentioned before, this will be overwritten during the next release

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.