[bitnami/superset] Add chart #26713
[bitnami/superset] Add chart #26713
Conversation
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
carrodher
added
new-product
| @@ -0,0 +1,14 @@ | |||
| # Copyright Broadcom, Inc. All Rights Reserved. | |||
| # SPDX-License-Identifier: APACHE-2.0 | |||
|
|
|||
There was a problem hiding this comment.
You could add to the runtime-parameters.yaml:
web:
containerSecurityContext:
enabled: true
runAsUser: 1002
serviceAccount:
create: true
automountServiceAccountToken: trueAnd then add the block below here:
{{- $uid := .Vars.web.containerSecurityContext.runAsUser }}
check-user-info:
# The UID should always be either the one specified as vars (always a bigger number that the default)
# or the one randomly defined by openshift (larger values). Otherwise, the chart is still using the default value.
exec: if [ $(id -u) -lt {{ $uid }} ]; then exit 1; fi
exit-status: 0
{{ if .Vars.serviceAccount.automountServiceAccountToken }}
check-sa:
exec: cat /var/run/secrets/kubernetes.io/serviceaccount/token | cut -d '.' -f 2 | xargs -I '{}' echo '{}====' | fold -w 4 | sed '$ d' | tr -d '\n' | base64 -d
exit-status: 0
stdout:
- /serviceaccount.*name.*{{ .Env.BITNAMI_APP_NAME }}/
{{ end }}| /opt/bitnami/superset/superset_config.py: | ||
| mode: "0644" | ||
| filetype: file | ||
| exists: true | ||
| /opt/bitnami/superset/superset_home: | ||
| filetype: directory | ||
| exists: true |
There was a problem hiding this comment.
If you enabled any parameter to customize/extend this configuration, you could set that parameter in runtime-parameters.yaml and then test that the configuration file contains your customization (check what we do in Dremio with dremio.conf).
| beat: | ||
| enabled: true | ||
| flower: | ||
| enabled: true |
There was a problem hiding this comment.
Is there a way to test these services work as expected or is it enough with the current Cypress tests?
| # Various IDEs | ||
| .project | ||
| .idea/ | ||
| *.tmproj |
There was a problem hiding this comment.
Missing changelog:
| *.tmproj | |
| *.tmproj | |
| # Changelog | |
| CHANGELOG.md |
| version: 2.x.x | ||
| description: Apache Superset is a Data Visualization and Data Exploration Platform | ||
| home: https://bitnami.com | ||
| icon: https://bitnami.com/assets/stacks/superset/img/superset-stack-220x234.png |
| - podSelector: | ||
| matchLabels: | ||
| {{ printf "%s-flower" (include "common.names.fullname" .) }}-client: "true" | ||
| {{- if .Values.flower.networkPolicy.ingressNSMatchLabels }} | ||
| - namespaceSelector: | ||
| matchLabels: | ||
| {{- range $key, $value := .Values.flower.networkPolicy.ingressNSMatchLabels }} | ||
| {{ $key | quote }}: {{ $value | quote }} | ||
| {{- end }} | ||
| {{- if .Values.flower.networkPolicy.ingressNSPodMatchLabels }} | ||
| podSelector: | ||
| matchLabels: | ||
| {{- range $key, $value := .Values.flower.networkPolicy.ingressNSPodMatchLabels }} | ||
| {{ $key | quote }}: {{ $value | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Not following new standard, (check template/CHART_NAME/templates/networkpolicy.yaml)
| {{- if eq "true" (include "common.ingress.supportsPathType" $) }} | ||
| pathType: {{ default "ImplementationSpecific" .pathType }} | ||
| {{- end }} | ||
| backend: {{- include "common.ingress.backend" (dict "serviceName" (include "common.names.fullname" $) "servicePort" "http" "context" $) | nindent 14 }} |
There was a problem hiding this comment.
Wrong backend:
| backend: {{- include "common.ingress.backend" (dict "serviceName" (include "common.names.fullname" $) "servicePort" "http" "context" $) | nindent 14 }} | |
| backend: {{- include "common.ingress.backend" (dict "serviceName" (printf "%s-web" (include "common.names.fullname" .)) "servicePort" "http" "context" $) | nindent 14 }} |
| metadata: | ||
| name: {{ printf "%s-init" (include "common.names.fullname" .) }} | ||
| namespace: {{ include "common.names.namespace" . | quote }} | ||
| {{- $versionLabel := dict "app.kubernetes.io/version" ( include "common.images.version" ( dict "imageRoot" .Values.image "chart" .Chart ) ) }} |
There was a problem hiding this comment.
This uses the default image, hence its the same value for app.kubernetes.io/version and you can skip this
| - name: http | ||
| port: {{ .Values.web.service.ports.http }} | ||
| targetPort: http | ||
| protocol: TCP | ||
| {{- if and (or (eq .Values.web.service.type "NodePort") (eq .Values.web.service.type "LoadBalancer")) (not (empty .Values.web.service.nodePorts.http)) }} | ||
| nodePort: {{ .Values.web.service.nodePorts.http }} | ||
| {{- else if eq .Values.web.service.type "ClusterIP" }} | ||
| nodePort: null | ||
| {{- end }} |
| ## | ||
| pullSecrets: [] | ||
| debug: false | ||
| ## |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
bitnami-bot
added
stale
carrodher
added
the
on-hold
Description of the change
Adds the bitnami/superset chart to the catalog.