Skip to content

Commit

Permalink
[bitnami/mlflow] Update externalS3.host example
Browse files Browse the repository at this point in the history 
AWS S3 HTTP endpoints are always regional, with `s3.amazonaws.com`
defaulting to us-east-1. To avoid issues when using buckets from
other regions, we should encourage including region code in the host.

Fixes: #23959

Signed-off-by: Jasper Orschulko <[email protected]>
  • Loading branch information
@Jasper-Ben
Jasper-Ben committed Aug 21, 2024
1 parent bb05f9f commit c5c159f
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion bitnami/mlflow/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ sources:
- https://github.com/bitnami/charts/tree/main/bitnami/mlflow
- https://github.com/bitnami/containers/tree/main/bitnami/mlflow
- https://github.com/mlflow/mlflow
version: 1.4.22
version: 1.4.23
28 changes: 14 additions & 14 deletions bitnami/mlflow/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -446,19 +446,19 @@ The command deploys mlflow on the Kubernetes cluster in the default configuratio

### External S3 parameters

| Name | Description | Value |
| ----------------------------------------- | ------------------------------------------------------------------ | --------------- |
| `externalS3.host` | External S3 host, e.g. "s3.amazonaws.com" | `""` |
| `externalS3.port` | External S3 port number | `443` |
| `externalS3.useCredentialsInSecret` | Whether to use a secret to store the S3 credentials | `true` |
| `externalS3.accessKeyID` | External S3 access key ID | `""` |
| `externalS3.accessKeySecret` | External S3 access key secret | `""` |
| `externalS3.existingSecret` | Name of an existing secret resource containing the S3 credentials | `""` |
| `externalS3.existingSecretAccessKeyIDKey` | Name of an existing secret key containing the S3 access key ID | `root-user` |
| `externalS3.existingSecretKeySecretKey` | Name of an existing secret key containing the S3 access key secret | `root-password` |
| `externalS3.protocol` | External S3 protocol | `https` |
| `externalS3.bucket` | External S3 bucket | `mlflow` |
| `externalS3.serveArtifacts` | Whether artifact serving is enabled | `true` |
| Name | Description | Value |
| ----------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------- |
| `externalS3.host` | External S3 host. When using AWS S3, include appropriate [regional code](https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region), e.g. "eu-central-1.amazonaws.com | `""` |
| `externalS3.port` | External S3 port number | `443` |
| `externalS3.useCredentialsInSecret` | Whether to use a secret to store the S3 credentials | `true` |
| `externalS3.accessKeyID` | External S3 access key ID | `""` |
| `externalS3.accessKeySecret` | External S3 access key secret | `""` |
| `externalS3.existingSecret` | Name of an existing secret resource containing the S3 credentials | `""` |
| `externalS3.existingSecretAccessKeyIDKey` | Name of an existing secret key containing the S3 access key ID | `root-user` |
| `externalS3.existingSecretKeySecretKey` | Name of an existing secret key containing the S3 access key secret | `root-password` |
| `externalS3.protocol` | External S3 protocol | `https` |
| `externalS3.bucket` | External S3 bucket | `mlflow` |
| `externalS3.serveArtifacts` | Whether artifact serving is enabled | `true` |

The MLflow chart supports three different ways to load your files in the `run` deployment. In order of priority, they are:

Expand Down Expand Up @@ -509,4 +509,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
2 changes: 1 addition & 1 deletion bitnami/mlflow/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1397,7 +1397,7 @@ minio:
api: 80
## @section External S3 parameters
## All of these values are only used when minio.enabled is set to false
## @param externalS3.host External S3 host, e.g. "s3.amazonaws.com"
## @param externalS3.host External S3 host. When using AWS S3, include appropriate [regional code](https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region), e.g. "eu-central-1.amazonaws.com
## @param externalS3.port External S3 port number
## @param externalS3.useCredentialsInSecret Whether to use a secret to store the S3 credentials
## @param externalS3.accessKeyID External S3 access key ID
Expand Down

0 comments on commit c5c159f

Please sign in to comment.