Completed new Settings menu #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itmovin/bitmovin-player-ui into feature/complete-settings-menu
…subtitles in the settings menu page
stonko1994
reviewed
Aug 27, 2024
stonko1994
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented a new Settings Menu. Now the settings are selected in a submenu instead of a drop down menu.
Sub-Settings are getting dynamically loaded and appended to the DOM tree.
Changed a little bit of the design of the settings menu.
Subtitle settings are not integrated yet.
Checklist (for PR submitter and reviewers)
CHANGELOGentry