Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new seekbar option to prevent label overlap #584

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

oberhamsi
Copy link
Contributor

potential fix for #569

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Simon Oberhammer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@felix-hoc
Copy link
Contributor

felix-hoc commented Feb 14, 2024

Thanks for the submission! :) I tested it a bit - unfortunately, the thumbnails seem to jump around wildly when getting close to the edges, and also the arrow disappears:
Screencast.webm

I think we need to find a different solution.

@oberhamsi
Copy link
Contributor Author

wouldn't call it "wildly" ;) it moves inside so it doesn't overlap. any suggestions on a direction to take on this?

@felix-hoc
Copy link
Contributor

Yeah I get that :) From a user perspective, it would be nice if the thumbnail would simply stop moving out of the frame, so it stays "attached" to the left/right edge when the mouse moves further out.

I had a quick look but also couldn't come up with a better solution so far :/ we'll need to properly look into it.

@oberhamsi
Copy link
Contributor Author

i think i addressed both your concerns - the label now stays at the edge (with a bit of margin) instead of jumping away from it and the arrow keeps indicating the visible position

Screencast.from.2024-02-28.13.09.31.webm

@oberhamsi
Copy link
Contributor Author

any news on this? if you are worried about performance, i could throttle the overflow-prevention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants