Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default keyStepIncrements to 5 #304

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Change default keyStepIncrements to 5 #304

wants to merge 1 commit into from

Conversation

kazuhide
Copy link

Changed the default keyStepIncrements to 5

  • When the keyStepIncrements:leftRight value was 1, the volume slidebar couldn't be increased due to a floating point error (over 28).
  • Setting the value to >1 solved the issue. Although the value can be customized on the app UI, I'd like to suggest to change the default value.

When the leftRight value was 1, the volume slidebar couldn't be increased due to a floating point error over 28. Setting the value to >1 solved the issue.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@felix-hoc felix-hoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the step size would essentially change the behavior. Instead, I'd suggest to fix it by either making sure to return only integers from the Player, or looking into using Math.round() instead of floor(). But we'd have to test it to make sure it doesn't behave weirdly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants