* common routine for counting new capacity in RunContainer

* common routine for counting new capacity in MappeableArrayContainer

* common routine for counting new capacity in MappeableRunContainer

* common routine for counting new capacity in ArrayContainer

* checkstyle

* already optimal mappable array constructors

* container materialising already done

* binary search from start index

* incorrect start index

* binary search from start index also in MappeableRunContainer

* convert byte to int in a loop once only

* simplified comparison of byte arrays

* enrolled version should be the fastest

* some compareTo methods can be replaced by more simple and performant appropriate equals() method

* avoid duplicate method call

* closely related unnecessary local variable

* checkstyle

* comparison of reference is unnecessary

* unnecessary local variable

* condition covered by subsequent conditions

* mismatch simplification

* use long instead of byte[6]

* avoid backward value conversion, when original is available

* mismatch() has to return length of shorter array, when all elements are equal

* bugfix: bytes are reordered

* bugfix: low 6 bytes, not high ones

* bugfix: two different conditions cannot be merged into one

* Skip unnecessary offset computations

* Skip unnecessary offset computations for mappable bitmap

* advanceIfNeeded optimization

* expected and actual value swap

* cleanup mesh & warnings

* temporary performance comparison removed

* Update jmh/src/jmh/java/org/roaringbitmap/AdvanceIfNeededBenchmark.java

Co-authored-by: Daniel Lemire <[email protected]>

---------

Co-authored-by: Daniel Lemire <[email protected]>

* real iand between run and array container

* faster run container iteration

* real iandnot between array and run container

* real iandnot between array and run mappable container

* avoid compute cardinality for run container using contains() instead

* benchmark for optimized checkedAdd()

* benchmark uses enums for testing scenarios

* use isEmpty() on bitmap instead of getCardinality()

* not empty is correct

* skip use numberOfTrailingZeros() if value is equal to zero

* replaceChildren() optimization for Node256

* use of toUnsignedInt() when values are not empty

* replaceChildren() simplification for Node4 and Node16

* replaceChildren() optimization for Node48

* unintended import change

* temporary benchmark removed

* benchmark for removal top values from bitmap

* remove current value when iterating on bitmap works properly

* use remove() to delete first K values

* Added unit test for expose batchiterator.advanceIfNext bug

* Fix batchiterator's advanceIfNeeded to logic to handle run lengths of zero

* Addressed comments

…gths of zero (#691)

…n from array containers to bitmap (#683)

* code deduplication in ior() for array containers

* code deduplication when converting to bitmap from array containers

* use ixor() instead of xor() to avoid cloning

…ap slice index (#693)

* use isEmpty() on bitmap instead of getCardinality()

* not empty is correct

* avoid compute cardinality for run container using contains() instead

* benchmark for optimized checkedAdd()

* benchmark uses enums for testing scenarios

* benchmark for removal top values from bitmap

* remove current value when iterating on bitmap works properly

* use remove() to delete first K values

* addOffset() optimized for array containers

* avoid use of local variable for optimized version

* use of local variable variant is the most performant

* renamed methods due to their confusing overloading

* rangeMask simplification

* rangeMask from number of slices simplification

* benchmark for deserialization mutable bitmaps

* avoid long buffer duplication

* avoid copy whole long array

* avoid long buffer duplication

* select from right if index is in upper half of cardinality

* skip zeroes

* benchmark for select from both sides

* bugfix

* variable name correction

)

* avoid useless operations in oNeilCompare()

* avoid instantiation unused empty bitmaps

* optimized run container's contains() with bitmap

* optimized mappable run container's contains() with bitmap

* test + benchmark for contains()

* benchmark correction

* benchmark correction

* checkstyle

* removed comparison for optimized contains() of (Mappeable)RunContainer

* more effective bitmapOf

* unify coding way

* more effective bitmapOf for buffered bitmap

…ible (#712)

* org.roaringbitmap.BatchIterator.nextBatch promises, in a comment, that its implementations "Aims to fill the buffer", but the two implementations of this will stop at the first consumption, even if there are many more ordinals to consume in later containers. This is muddying the idea of a container (which is essentially a roaring bitmap batch) and the user's batch (which may be smaller or larger than the roaring bitmap container cardinality). This commit attempts to make the implementation match the promise. Considering how long this implementation has been out of step with the comment, this may not be the best solution to merge upstream, but it's the solution my team would prefer. Implementation only, tests to follow.

* fixup compilation, existing tests, and checkstyle. Still WIP, as we're missing tests for our specific functionality.

* add test for batches that are across multiple containers will fill the buffer

* now that we have our own tests for filling the buffer, leave the original testIndependenceOfClones2 tests closer to their original implementation

* RoaringBitmap to BitSet/long[]/byte[]. Fixes #556

* Prevent bitmaps with negative bits from being converted. Add variant that avoids an intermediate array

* Fix javadoc typos

…by Eclipse Temurin (see https://adoptium.net/support/) (#719)

…tainer (#718)

* Add test and fix for or:ing two RunContainers that produce an undersized BitmapContainer combined

* Also fix MappeableRunContainer and remove unused methods

…alue (#720)

* fix: formalize edge behaviour for nextAbsentValue and previousAbsentValue

* simplifying

should not advance to the next bit when advancing to the next run

off-by-one error

* Add RoaringBitSet

* Add RoaringBitSet

* Address review comments

* Address review comments

* Move to static for BitmapContainer.MAXRUNS

* ported static correction to mappeable container

---------

Co-authored-by: Danny Thomas <[email protected]>

* improve: Optimize RoaringBitSet.get(int fromIndex, int toIndex)

* Add range check

* Simplify implementation based on review feedback

* fix: add bitmapOfRange (non-static)

* lint

* add getSignedIntIterator to roaring bitmaps and use integers above 2^31 in the test iterators.

We sometimes use roaring bitmaps for iterative filtering where the opposite side of the join is sorted using signed comparison. Create a function to peekable int iterator to more easily allow that.

* comment cleanup

* comment cleanup

* @zoltanmeze caught that I meant we skip to the negative numbers when doing a signed int sort, not positive numbers. fixup comment.

* adds failing test for issue 730

* fixes BitmapBatchIterator.hasNext to return accurate result for empty containers

…ting container index (#734)

* Use advanceUntil to find starting container index

* Allow advanceIfNeeded to wrap around in signed int iterators

* Simplify finding starting container index

* Step down container index if next present container key is larger than target container key

This means that previous value (if exist) must be always in the previous container

* Return value as unsigned long when previous value is also the last (largest) value in bitmap

* Remove unnecessary condition

* Skip empty words while iterating over bitmap container in RunContainer#contains(BitmapContainer)

* Format

* Implement first and last signed methods

Allows retrieving minimum and maximum signed integers from bitmap

* Remove unnecessary (duplicate) javadoc

* Add BSI based on Roaring64Bitmap so as to support (cid:bigint, value:bigint)

* Change implementation of Roaring64Bitmap's or and xor (not in place) operation

* Fix variable name

* Add some analysis functions

* Fix variable type

* fix some problem

---------

Co-authored-by: zhangpeicheng <[email protected]>

* Changes for adding container size

* Changes for adding container size

* Changes for adding container size

* common routine for bitmap keys intersection

* common routine for immutable bitmap keys intersection

* common routine for conversion bitmap array to array of values

* merge new methods with existing one

* Update RoaringBitmap/src/main/java/org/roaringbitmap/buffer/BufferUtil.java

Co-authored-by: Daniel Lemire <[email protected]>

* Update RoaringBitmap/src/main/java/org/roaringbitmap/Util.java

Co-authored-by: Daniel Lemire <[email protected]>

---------

Co-authored-by: Daniel Lemire <[email protected]>