fix: Record the missing-error-handler timers in TCPHelper, UDPHelper,…

… and TelnetHelper, and properly clear them when destroy() is called. (#78)

src/helpers/tcp.ts

@@ -60,6 +60,7 @@ export class TCPHelper extends EventEmitter<TCPHelperEvents> {
 	#destroyed = false
 	#lastStatus: InstanceStatus | undefined
 	#reconnectTimer: NodeJS.Timeout | undefined
+	#missingErrorHandlerTimer: NodeJS.Timeout | undefined
 
 	get isConnected(): boolean {
 		return this.#connected
@@ -123,7 +124,8 @@ export class TCPHelper extends EventEmitter<TCPHelperEvents> {
 		// Let caller install event handlers first
 		setImmediate(() => this.connect())
 
-		setTimeout(() => {
+		this.#missingErrorHandlerTimer = setTimeout(() => {
+			this.#missingErrorHandlerTimer = undefined
 			if (!this.#destroyed && !this.listenerCount('error')) {
 				// The socket is active and has no listeners. Log an error for the module devs!
 				console.error(`Danger: TCP client for ${this.#host}:${this.#port} is missing an error handler!`)
@@ -175,6 +177,11 @@ export class TCPHelper extends EventEmitter<TCPHelperEvents> {
 
 		if (this.#reconnectTimer !== undefined) {
 			clearTimeout(this.#reconnectTimer)
+			this.#reconnectTimer = undefined
+		}
+		if (this.#missingErrorHandlerTimer !== undefined) {
+			clearTimeout(this.#missingErrorHandlerTimer)
+			this.#missingErrorHandlerTimer = undefined
 		}
 
 		this._socket.removeAllListeners()

src/helpers/telnet.ts

@@ -38,6 +38,7 @@ export type TelnetHelperOptions = TCPHelperOptions
 export class TelnetHelper extends EventEmitter<TelnetHelperEvents> {
 	readonly #tcp: TCPHelper
 	readonly #stream: TelnetStream
+	#missingErrorHandlerTimer: NodeJS.Timeout | undefined
 
 	get isConnected(): boolean {
 		return this.#tcp.isConnected
@@ -68,7 +69,8 @@ export class TelnetHelper extends EventEmitter<TelnetHelperEvents> {
 		this.#stream.on('data', (data) => this.emit('data', data))
 		this.#stream.on('drain', () => this.emit('drain'))
 
-		setTimeout(() => {
+		this.#missingErrorHandlerTimer = setTimeout(() => {
+			this.#missingErrorHandlerTimer = undefined
 			if (!this.isDestroyed && !this.listenerCount('error')) {
 				// The socket is active and has no listeners. Log an error for the module devs!
 				console.error(`Danger: Telnet client for ${host}:${port} is missing an error handler!`)
@@ -86,6 +88,11 @@ export class TelnetHelper extends EventEmitter<TelnetHelperEvents> {
 	destroy(): void {
 		this.#tcp.destroy()
 
+		if (this.#missingErrorHandlerTimer !== undefined) {
+			clearTimeout(this.#missingErrorHandlerTimer)
+			this.#missingErrorHandlerTimer = undefined
+		}
+
 		this.#stream.removeAllListeners()
 		this.#stream.destroy()
 	}

src/helpers/udp.ts

@@ -58,6 +58,7 @@ export class UDPHelper extends EventEmitter<UDPHelperEvents> {
 
 	#destroyed = false
 	#lastStatus: InstanceStatus | undefined
+	#missingErrorHandlerTimer: NodeJS.Timeout | undefined
 
 	get isDestroyed(): boolean {
 		return this.#destroyed
@@ -117,7 +118,7 @@ export class UDPHelper extends EventEmitter<UDPHelperEvents> {
 
 		this.#socket.on('message', (data) => this.emit('data', data))
 
-		setTimeout(() => {
+		this.#missingErrorHandlerTimer = setTimeout(() => {
 			if (!this.#destroyed && !this.listenerCount('error')) {
 				// The socket is active and has no listeners. Log an error for the module devs!
 				console.error(`Danger: UDP socket for ${this.#host}:${this.#port} is missing an error handler!`)
@@ -150,6 +151,11 @@ export class UDPHelper extends EventEmitter<UDPHelperEvents> {
 	destroy(): void {
 		this.#destroyed = true
 
+		if (this.#missingErrorHandlerTimer !== undefined) {
+			clearTimeout(this.#missingErrorHandlerTimer)
+			this.#missingErrorHandlerTimer = undefined
+		}
+
 		this.#socket.removeAllListeners()
 		this.#socket.close()
 		this.removeAllListeners()