Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maven-publish.gradle to enable publishing to GitLab #56

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add maven-publish.gradle to enable publishing to GitLab #56

merged 1 commit into from
Sep 3, 2024
+38 −1

Conversation

msgilligan
Copy link
Member

No description provided.

@msgilligan msgilligan mentioned this pull request Apr 29, 2024
Closed
@msgilligan
Copy link
Member Author

This is DRAFT, because I want to see if I can change allprojects back to subprojects.

@msgilligan msgilligan force-pushed the msgilligan/maven-publish branch 2 times, most recently from 2935d91 to 3e9cd03 Compare September 3, 2024 18:03
@msgilligan msgilligan added this to the Version 0.0.2 milestone Sep 3, 2024
@msgilligan
Copy link
Member Author

This is DRAFT, because I want to see if I can change allprojects back to subprojects.

This has been fixed and force-pushed.

I also added ext.publishedProjects = ['secp-api', 'secp-ffm', 'secp-bouncy'] so that only the three main libraries are published to Maven.

@msgilligan msgilligan marked this pull request as ready for review September 3, 2024 18:09
schildbach
schildbach approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@schildbach schildbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the specific case of GitLab actions, it makes sense to link to a CI run of your branch at GitLab, so I can look at the logs and the build artifacts.

@msgilligan
Copy link
Member Author

In the specific case of GitLab actions, it makes sense to link to a CI run of your branch at GitLab, so I can look at the logs and the build artifacts.

I haven't added GitLab CI yet. I'm just going to publish to GitLab's project-level Maven repository. We should add GitLab CI in the future.

@msgilligan msgilligan merged commit 1a80a69 into master Sep 3, 2024
6 checks passed
@msgilligan msgilligan deleted the msgilligan/maven-publish branch September 3, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schildbach schildbach schildbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@msgilligan @schildbach