Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods on Txbuilder #430

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Add methods on Txbuilder #430

merged 7 commits into from
Dec 14, 2023

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Dec 7, 2023 •
edited
Loading

This PR adds a few new methods on the TxBuilder.

Todo:

  • tests
  • Open up BumpFeeTxBuilder

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature

@thunderbiscuit thunderbiscuit self-assigned this Dec 7, 2023
@thunderbiscuit thunderbiscuit added this to the alpha.3 milestone Dec 7, 2023
@thunderbiscuit thunderbiscuit marked this pull request as ready for review December 14, 2023 17:51
@thunderbiscuit thunderbiscuit mentioned this pull request Dec 14, 2023
Merged
reez
reez reviewed Dec 14, 2023
View reviewed changes
bdk-swift/Tests/BitcoinDevKitTests/LiveTxBuilderTests.swift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this code shows up as grey in the GitHub UI here? Regardless it looks good to me locally

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird... no I haven't seen this before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah I think it's related to the /* used in the descriptor on line 7. Is that maybe a long-form comment that the IDE interprets as never closed?

reez
reez approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bbc6e1a

Reviewed, tested locally, nice job w the tests across all 4 platforms.

@thunderbiscuit thunderbiscuit merged commit bbc6e1a into bitcoindevkit:master Dec 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reez reez reez approved these changes

Assignees

@thunderbiscuit thunderbiscuit

Labels
None yet
Projects
BDK-Bindings
Archived in project
Milestone
alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@thunderbiscuit @reez