Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix to work with bdk 0.28.2 and msrv 1.61.0 #389

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 3, 2023

Description

Fixes CI to work with BDK 0.28.x and MSRV 1.61.0. For MSRV had to pin two dependencies.

Notes to the reviewers

I also updated in CI our 'stable" version of rust to be current stable which is 1.71.0.

Changelog notice

None, only CI changes.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory changed the title Fix msrv 1.61.0 ci: fix to work with bdk 0.28.1 and msrv 1.61.0 Aug 3, 2023
@notmandatory notmandatory force-pushed the fix_msrv_1610 branch 3 times, most recently from 5df83c4 to 9b421b4 Compare August 3, 2023 22:03
@notmandatory notmandatory changed the title ci: fix to work with bdk 0.28.1 and msrv 1.61.0 ci: fix to work with bdk 0.28.2 and msrv 1.61.0 Aug 10, 2023
@notmandatory notmandatory self-assigned this Aug 10, 2023
@notmandatory notmandatory added the CI Continuous integration pipeline related label Aug 10, 2023
@notmandatory notmandatory added this to the Release 0.30.0 milestone Aug 10, 2023
@notmandatory notmandatory marked this pull request as ready for review August 10, 2023 16:52
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1da01b4.

notmandatory added a commit that referenced this pull request Aug 10, 2023
1da01b4 ci: change rust stable version to 0.71.0 (Steve Myers)
f1ba03b ci: fix to work with bdk 0.28.1 and msrv 1.61.0 (Steve Myers)

Pull request description:

  ### Description

  Fixes CI to work with BDK 0.28.x and MSRV 1.61.0. For MSRV had to pin two dependencies.

  ### Notes to the reviewers

  I also updated in CI our 'stable" version of rust to be current stable which is `1.71.0`.

  ### Changelog notice

  None, only CI changes.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing
@notmandatory notmandatory merged commit faf23b7 into bitcoindevkit:master Aug 10, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration pipeline related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants