Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: adding unit tests #387

Closed
wants to merge 3 commits into from
Closed

Conversation

reez
Copy link
Collaborator

@reez reez commented Jul 18, 2023

Description

Adding Unit Tests for Swift

Notes to the reviewers

Unit tests will try to include as much:

  • parity with JVM / Android
    • added a few private variables for reusability (similar to JVM/Android)
    • updated testMemoryWalletNewAddress to use testnet (similar to JVM/Android)
    • added testMemoryWalletBalance (similar to JVM/Android)
  • parity with bitcoindevkit-scripts Swift

Can run swift test on this file via command line.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant