Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign / verify for arbitrary messages #139

Closed
wants to merge 3 commits into from
Closed

Add sign / verify for arbitrary messages #139

wants to merge 3 commits into from

Conversation

q-src
Copy link

@q-src q-src commented Apr 12, 2022

This PR adds support for the creation of signatures of arbitrary messages and their verification. A PR for bdk-kotlin will follow.

Signatures can be created using a given wif, prv or xprv. They can be verified using a pub, xpub or address.

Since these are my very first steps with Rust, please take a closer look at the coding style as well.

@q-src q-src changed the title Add sign / verify for aribtrary messages Add sign / verify for arbitrary messages Apr 12, 2022
@q-src q-src mentioned this pull request Apr 12, 2022
@notmandatory
Copy link
Member

This looks cool! I'll take a look and it might be something we want to have in bdk eventually.

@notmandatory notmandatory self-requested a review April 16, 2022 05:44
@thunderbiscuit
Copy link
Member

@q-src we've discussed this in 2 dev calls and think it might be valuable to have as part of the core Rust bitcoindevkit. Are you interested in opening a PR to add the feature right in bdk?

Also our dev calls are open and bi-weekly, so if ever that's something you're interested in joining we'd love to have you. You can join our Discord and you'll find all the info there. Cheers!

@q-src
Copy link
Author

q-src commented May 6, 2022

Thanks for the feedback @thunderbiscuit. I opened a PR at bdk: bitcoindevkit/bdk#601

Sure, I am happy to join the dev calls :)

@thunderbiscuit
Copy link
Member

Awesome! You can find the notes and proposed agenda for the upcoming calls both for the core Rust library and the language bindings here.

I keep the agenda for the language bindings evergreen here.

@thunderbiscuit
Copy link
Member

Closing in favour of bitcoindevkit/bdk#601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants