Skip to content

Commit

Permalink
Temp 22: Fix Android cross-compilation issues
Browse files Browse the repository at this point in the history
  • Loading branch information
thunderbiscuit committed Oct 16, 2023
1 parent 3072962 commit 5236b6c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ jobs:
run:
working-directory: bdk-ffi
steps:
- uses: actions/checkout@v3
- uses: actions-rs/audit-check@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: "Check out PR branch"
uses: actions/checkout@v3

- name: "Run audit"
run: |
cargo install cargo-audit
cargo-audit audit
7 changes: 6 additions & 1 deletion bdk-ffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@ default = ["uniffi/cli"]
[dependencies]
bdk = { version = "1.0.0-alpha.2", features = ["all-keys", "keys-bip39"] }
bdk_file_store = { version = "0.2.0" }
bdk_esplora = { version = "0.4.0" }
# TODO 22: the bdk_esplora crate uses esplora_client which uses reqwest for async. By default it uses the system
# openssl library, which is creating problems for cross-compilation. I'd rather use rustls, but it's hidden
# behind a feature flag. We need to look into whether openssl-sys is really required by bdk or if using rustls
# would work just as well. This here is a temporary workaround which removes the async feature on the bdk_esplora crate.
bdk_esplora = { version = "0.4.0", default-features = false, features = ["std", "blocking"] }
uniffi = { version = "=0.23.0" }
# reqwest = { version = "0.11", default-features = false, features = ["rustls-tls"] }

[build-dependencies]
uniffi = { version = "=0.23.0", features = ["build"] }
Expand Down

0 comments on commit 5236b6c

Please sign in to comment.