Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new layout D_X,E_X for BB51. #196

Merged
merged 6 commits into from
Aug 11, 2024

Conversation

HAKRC
Copy link
Contributor

@HAKRC HAKRC commented Jul 19, 2024

I've added D_X and E_X layouts for BB51, and E_X_40_24 and E_X_40_48 have been validated, but D_X has not yet been validated.

Copy link

Build artifacts:

@stylesuxx
Copy link
Contributor

Thank you for your contribution! In our manufacturer discord we asked - quite some time ago - if anyone uses those layouts. And if so, if we could get samples.

We do not want to clutter the layouts with untested, unverified layouts - that's why we have not added them yet.

Are you going to use (and verify) the D Layout too?

Any chance you could provide some samples for each layout? Would be great to have something as reference just in case users run into problems so we have some hardware to test against.

@HAKRC
Copy link
Contributor Author

HAKRC commented Jul 19, 2024 via email

@stylesuxx
Copy link
Contributor

Hey, I pinged you (Hackrc Wang) on discord in our manufacturer chat, let's continue discussion there.

@stylesuxx stylesuxx added this to the v0.21.1 milestone Jul 20, 2024
src/Bluejay.asm Outdated Show resolved Hide resolved
Copy link

Build artifacts:

@stylesuxx stylesuxx changed the base branch from main to develop July 22, 2024 10:52
Copy link
Contributor

@stylesuxx stylesuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor formatting nitpicks.

src/Layouts/Base.inc Outdated Show resolved Hide resolved
src/Layouts/Base.inc Outdated Show resolved Hide resolved
src/Layouts/Base.inc Outdated Show resolved Hide resolved
Format adjustment,Add spaces before and after + & -
Copy link

Build artifacts:

@hyp0dermik-code
Copy link
Contributor

The new layouts need to be added to Bluejay.asm after L118:
https://github.com/HAKRC/bluejay/blob/bed3edb9e378fa559baf4541a8214e63d01b48ff/src/Bluejay.asm#L115

Add D_and E_ macro definition in Bluejay.asm
Correct annotation in E.inc
Copy link

Build artifacts:

@hyp0dermik-code
Copy link
Contributor

The Makefile needs to be altered to include the new layouts too:

LAYOUTS_X               = A B C D E

Copy link

github-actions bot commented Aug 6, 2024

Build artifacts:

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 8, 2024

We have sent you the boards with D_X and E_X layouts. Have you received them?

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 8, 2024

"We hope the latest firmware is updated to https://esc-configurator.com/, so our customers can update the code and configuration there."

@stylesuxx stylesuxx linked an issue Aug 11, 2024 that may be closed by this pull request
8 tasks
Copy link
Contributor

@stylesuxx stylesuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. Bench tested D&E layout. Defaults come flashed with BLHeli_S. Tested stock, flashed Bluejay, made sure power consumtion is in a similar range and motors spin smoothly. RPM is reported in Betaflight configurator.

Also see #207

Configurator needs to be re-deployed after this change.

@hyp0dermik-code hyp0dermik-code merged commit 4d47ae4 into bird-sanctuary:develop Aug 11, 2024
1 check passed
@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 12, 2024

Can I ask about the release date of the new version?

@stylesuxx
Copy link
Contributor

stylesuxx commented Aug 12, 2024

We are planning on releasing a RC later today.

@hyp0dermik-code
Copy link
Contributor

@HAKRC the RC has been released and can be downloaded via https://esc-configurator.com by enabling Show firmware pre-releases in the Settings of https://esc-configurator.com
image

If you do not see this, make sure your esc-configurator.com is up to date, either by the popup or force-refreshing the page.

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 16, 2024

We are planning on releasing a RC later today.

We appreciate it .

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 16, 2024

@HAKRC the RC has been released and can be downloaded via https://esc-configurator.com by enabling Show firmware pre-releases in the Settings of https://esc-configurator.com image

If you do not see this, make sure your esc-configurator.com is up to date, either by the popup or force-refreshing the page.

企业微信截图_17237071661312
There are some issues. When I downloaded the D_X and E_X v0.21 firmware from https://esc-configurator.com/, it failed and showed an error saying 'unable to open the file'.

@stylesuxx
Copy link
Contributor

stylesuxx commented Aug 16, 2024

Can you please post the log? If possible please also switch to english so we can understand what's going on here.
Also have you tried downloading the hex files from the release section and flashing them from disk?

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 19, 2024

Can you please post the log? If possible please also switch to english so we can understand what's going on here. Also have you tried downloading the hex files from the release section and flashing them from disk?

kappframework-QZQKpC(1)(1)
kappframework-uiwirS(1)(1)

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 19, 2024

Can you please post the log? If possible please also switch to english so we can understand what's going on here. Also have you tried downloading the hex files from the release section and flashing them from disk?

Yes,the hex files from the release section have already passed testing,but I flashed the D_X and E_X v0.21 file from https://esc-configurator.com/, it failed and showed an error saying 'Could not get file for flashing'.

@hyp0dermik-code
Copy link
Contributor

You are flashing the wrong version.
This target was only added in 0.21.1-RC1, flash that version as per my instructions here #196 (comment)

@HAKRC
Copy link
Contributor Author

HAKRC commented Aug 19, 2024

You are flashing the wrong version. This target was only added in 0.21.1-RC1, flash that version as per my instructions here #196 (comment)

Thank you for your help.We have succeeded to downloaded E_X_v0.21.1-RC1 from https://esc-configurator.com/,and passed the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

D_X_* & E_X_* Layout
3 participants