Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BioSQL wiki page to reflect the latest version #136

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

leptoceratops
Copy link

Added cygwin support as well.

@peterjc
Copy link
Member

peterjc commented Sep 24, 2018

Our automated checks failed, but its an easy thing to fix:

$ if grep -n -r '[[:blank:]]$' wiki/*.md; then echo 'Please remove trailing whitespace.'; false; fi
wiki/BioSQL.md:78:Once the software is installed, your next task is to setup a database, 
wiki/BioSQL.md:264:database, you have to tell the unit test a few bits of information. 
wiki/BioSQL.md:265:If you installed biopython using pip then the relevant [**Tests**](https://github.com/biopython/biopython/tree/master/Tests) 
wiki/BioSQL.md:266:folder would not have been copied. If this is the case one can 
Please remove trailing whitespace.

Copy link
Member

@peterjc peterjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally very positive - much needed overdue updates. My comments are mainly stylistic.

wiki/BioSQL.md Outdated
perform check out (or export) using:

```bash
svn export https://github.com/biopython/biopython/trunk/Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't recommend using svn here. If you want to avoid needing git, we can just download a tar-ball or zip file from GitHub using e.g.

wget https://github.com/biopython/biopython/archive/biopython-172.zip
unzip biopython-172.zip

Or,

wget https://github.com/biopython/biopython/archive/biopython-172.tar.gz
tar -zxvf biopython-172.tar.gz

Also this lets us recommend getting the tests to match the version of Biopython installed, which should prevent test failures from a version mis-match (although that would be rare with BioSQL as this code is fairly static these days).

repository at (https://github.com/biosql/biosql.git)

``` bash
svn export https://github.com/biosql/biosql.git/trunk biosql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, avoid recommending the legacy tool svn here - we want any potential contributors to use git so:

git clone https://github.com/biosql/biosql.git
cd biosql

Or, for a simple snapshot:

wget https://github.com/biosql/biosql/archive/master.tar.gz
tar -zxvf master.tar.gz
cd biosql-master/

The BioSQL package includes a perl script under
scripts/load\_ncbi\_taxonomy.pl to download and update the taxonomy
The BioSQL package includes a perl script under the
**scripts** subdirectory named **load\_ncbi\_taxonomy.pl** that downloads and updates the taxonomy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the double back-ticks for file names, load\_ncbi\_taxonomy.pl, rather than double asterisk for bold.

@@ -92,8 +107,7 @@ mysqladmin -u root create bioseqdb
```

We can then tell MySQL to load the BioSQL scheme we downloaded above.
Change to the scripts subdirectory from the unzipped BioSQL download,
then:
Change to the **sql** subdirectory (see above) and then:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the double back-ticks for directory names, sql, rather than the double asterisk for bold.

@@ -191,8 +205,7 @@ trying to load sequences into the database. This isn't so important with
Biopython 1.49 onwards, where you can instead opt to have the
information needed downloaded as needed from Entrez.

To update the NCBI taxonomy, change to the scripts subdirectory from the
unzipped BioSQL download, then:
To update the NCBI taxonomy, change to the **scripts** subdirectory (see above) and then:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts

DBDRIVER = 'MySQLdb'
DBTYPE = 'mysql'
```bash
svn export https://github.com/biopython/biopython/trunk/Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, please avoid svn export and use git or a plain download from GitHub.

```

and a little lower down,
Inside *Tests*, copy the file *biosql.ini.sample* to *biosql.ini* and edit it by filling in the following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double-backtickes, Tests, biosql.ini.sample and biosql.ini - not single asterisk for italics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants