Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in environmental variable to pkg_test #222

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

jerowe
Copy link

@jerowe jerowe commented Nov 16, 2017

@bgruening

Here is a really simple and possibly stupid way to fix the hardcoded biocontainers problem.

Let me know if you think there is a better way to do this.

@jerowe
Copy link
Author

jerowe commented Nov 16, 2017

I think it would be best to get it from the command line argument, but I need to sit down and figure out how to do that.

@@ -126,11 +126,15 @@ def test_package(
tests = get_tests(path)
logger.debug('Tests to run: %s', tests)

target = 'biocontainers'
if os.environ.get('QUAY_TARGET') is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it CONTAINER_NAMESPACE or something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can name it whatever you like . ;-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

@bgruening
Copy link
Member

A proper fix with command line args would be better I agree. But I'm also not opposed to merge this one for the time being.

@jerowe
Copy link
Author

jerowe commented Nov 19, 2017

I can confirm that this works. ;-)

@jerowe
Copy link
Author

jerowe commented Nov 19, 2017

@bgruening , I changed this so that it gets the original command line argument.

@epruesse
Copy link
Member

epruesse commented Jan 8, 2019

@jerowe @bgruening What is the status of this? Do we still need it?

@jerowe
Copy link
Author

jerowe commented Jan 18, 2019

@epruesse , yes, I would still like it. It was the last missing piece of the "let me coopt the bioconda built system to deploy my in house software stacks" puzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants