Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k8-1.0: enable linux-aarch64 build #46387

Closed
wants to merge 16 commits into from
Closed

add k8-1.0: enable linux-aarch64 build #46387

wants to merge 16 commits into from

Conversation

guozhicong
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be interested in attractivechaos/k8@207544a

requirements:
build:
- {{ compiler('cxx') }}
- _libgcc_mutex >=0.1
- _openmp_mutex >=4.5
- binutils_impl_linux-aarch64 2.40 h870a726_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong to me.
Why do you use **-aarch64 dependencies here ? How is the x86_64 supposed to use them ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-g I added this tag. Doesn't it mean it 's only available in linux-aarch64's repository of conda?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extra, i.e. in addition to the default platforms.
You need to use selectors, like ... # [aarch64 or osx] to specify that something is specific for some architecture

@guozhicong guozhicong changed the title add k8: enable linux-aarch64 build add k8-1.0: enable linux-aarch64 build Mar 18, 2024
@martin-g
Copy link
Contributor

@guozhicong May I take over ? I think I see a way how to finish this task!

@guozhicong
Copy link
Contributor Author

@guozhicong May I take over ? I think I see a way how to finish this task!

@martin-g Of course, I dont konw how to fix it.

@martin-g
Copy link
Contributor

#46559 - it almost works! But building Node.js from sources takes a lot of time!

@rpetit3 rpetit3 added the aarch64 Related to adding linux-aarch64 support label Mar 20, 2024
@martin-g
Copy link
Contributor

This PR could be closed in favour of #46559

@guozhicong guozhicong closed this by deleting the head repository Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants