-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nextclade: Enable linux-aarch64 #46185
Conversation
Not sure why this happens, it's the same build script as for linux64 which passes:
Need to run from source? but why is the aarch glibc version lower than linux-64? see conda-forge/tensorflow-feedstock#6 |
Skipping tests for aarch64 works - but isn't really super comforting - would be good to have a way of testing with current builder. See #46186 |
@corneliusroemer is the issue here that the prebuilt binaries are built with the newer GLIBC? |
Yes, Rust has raised minimum glibc version to something like 2.17 from 1.64 - and the builder has a very old glibc, see #46186 As the glibc used is the one at runtime not on the builder and all runtimes will have sufficiently recent glibc versions for nextclade to work I'd say we just bypass tests until there's a better way. what's strange is that tests run on x86 but not on aarch64 - there might be a slight difference been builders, again see #46186 I actually have quite an urgent use case for aarch64 bioconda nextclade so it'd be great if you could approve |
@BiocondaBot please fetch artifacts |
AzureNo artifacts found on the most recent Azure build. Either the build failed, the artifacts have been removed due to age, or the recipe was blacklisted/skipped. |
I've tried to work around the glibc issue but to no avail, see #46186 (comment) Given the precedent quoted there for disabling tests when glibc causes issues (tensorflow etc.) I would like to ask for approval to skip tests just for the aarch version here. |
@BiocondaBot please fetch artifacts |
AzurePackage(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images for Azure are in the LinuxArtifacts zip file above):
CircleCIPackage(s) built on CircleCI are ready for inspection:
You may also use
|
I manually tested the
|
@BiocondaBot please add label |
Bioconda now publishes linux-aarch64 packages for nextclade as well, so those shas also should be updated. bioconda/bioconda-recipes#46185
https://app.circleci.com/pipelines/github/bioconda/bioconda-recipes/109939/workflows/d6e1d687-5cdc-4c5d-865a-1ba0cb41b932/jobs/180788?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.