Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Openms 2.9.0 #39736

Merged
merged 16 commits into from
Mar 6, 2023
Merged

update: Openms 2.9.0 #39736

merged 16 commits into from
Mar 6, 2023

Conversation

jpfeuffer
Copy link
Contributor

Describe your pull request here

This is basically a pre-release of 3.0 until the installers and GUI stuff are tested.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jpfeuffer
Copy link
Contributor Author

@daler can I somehow force the order of the recipes? bioconda/bioconda-utils#751
is blocking.

@jpfeuffer
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Mar 6, 2023
@jpfeuffer
Copy link
Contributor Author

I have split the PR into openms and pyopenms now. Please consider fixing/merging bioconda/bioconda-utils#751 for next time.

@daler
Copy link
Member

daler commented Mar 6, 2023

@jpfeuffer have not forgotten about that bioconda-utils PR. There are a lot of other changes happening in bioconda-utils, trying to keep one thing changing at a time...

@daler
Copy link
Member

daler commented Mar 6, 2023

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 22961a0 into bioconda:master Mar 6, 2023
cokelaer pushed a commit to cokelaer/bioconda-recipes that referenced this pull request Apr 28, 2023
Merge PR bioconda#39736, commits were: 
 * recreate deleted files
 * revert pyopenms. has to be in a separate PR
 * revert simplifying config. apparently bioconda-build does NOT FOLLOW the official conda specification!
 * remove nightly specifics and simply config
 * try with matplotlib-base
 * try without matplotlib version
 * Apply suggestions from code review
 * adding matplotlib
 * Update conda_build_config.yaml
 * Update conda_build_config.yaml
 * Update conda_build_config.yaml
 * Update conda_build_config.yaml
 * move pyopenms config file into proper recipe
 * remove bumpershot
 * remove crux from meta.yaml
 * [UPDATE] (py)openms to 3.0 nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants