Merge pull request #3 from pveber/drop_fix3

bugfix of `drop` (also fixes `skip`)
biocaml · Jun 18, 2014 · 725de3c · 725de3c
2 parents 00432e0 + 7f5e94f
commit 725de3c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Changes.md b/Changes.md
@@ -2,6 +2,7 @@ CFStream Release Notes
 
 cfstream-1.1.2 2014-06-16
 -------------------------
+* bugfix on `drop` and `skip`
 * Reduced deps to core_kernel instead of core.
 
 cfstream-1.1.1 2014-03-02

diff --git a/src/lib/CFStream_stream.ml b/src/lib/CFStream_stream.ml
@@ -156,7 +156,8 @@ let rec drop_whilei xs ~f =
 let drop_while xs ~f = drop_whilei xs ~f:(const f)
 
 let drop xs ~n =
-  drop_whilei xs ~f:(fun j _ -> j < n)
+  let i = ref n in
+  drop_whilei xs ~f:(fun _ _ -> if !i > 0 then (decr i ; true) else false)
 
 let skip_whilei xs ~f =
   drop_whilei xs ~f ;